Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix trailing slash in media urls returned from heresphere api #1752

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix: Fix trailing slash in media urls returned from heresphere api #1752

merged 1 commit into from
Jul 2, 2024
+2 −2

Conversation

Yoooi0
Copy link
Contributor

@Yoooi0 Yoooi0 commented Jun 25, 2024

When using the /heresphere api the media urls are returned with a trailing slash:

http://localhost:9999/api/dms/file/1/
http://localhost:9999/api/dms/file/1/?dnt=true

This PR fixes it to:

http://localhost:9999/api/dms/file/1
http://localhost:9999/api/dms/file/1?dnt=true

Which also matches the /deovr api:

xbvr/pkg/api/deovr.go

Line 402 in 9f253fe

URL: fmt.Sprintf("%v/api/dms/file/%v/%v%v", session.DeoRequestHost, file.ID, scene.GetFunscriptTitle(), dnt),

Blame #969

@crwxaj crwxaj merged commit a079b71 into xbapps:master Jul 2, 2024
1 check passed
@Yoooi0 Yoooi0 deleted the fix-heresphere-api-url branch November 9, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yoooi0 @crwxaj